zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cornead...@apache.org
Subject incubator-zeppelin git commit: ZEPPELIN-324: Zeppelin-web builds fail on OSX due to PhantomJS port conflicts on port 8080
Date Tue, 29 Sep 2015 08:28:36 GMT
Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master f58c13a65 -> 9b198889d


ZEPPELIN-324: Zeppelin-web builds fail on OSX due to PhantomJS port conflicts on port 8080

The Zeppelin-Web module uses PhantomJS to run Karma JS unit tests. The test suite uses port
8080 by default and is supposed to detect port conflicts. However, on OSX, port conflicts
are not detected correctly, and the tests time out causing the Zeppelin build to fail.

I noticed that the test suite also uses port 9001- since 9002 is an uncommonly used port and
is close to already used 9001, this PR changes the PhantomJS default port to 9002, allowing
builds to proceed successfully.

Author: Randy Gelhausen <rgelhau@gmail.com>

Closes #327 from randerzander/master and squashes the following commits:

4694ce9 [Randy Gelhausen] Fixed Zeppelin-web Grunt build task


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/9b198889
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/9b198889
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/9b198889

Branch: refs/heads/master
Commit: 9b198889da5fae8cc6521437d9730594e362efd9
Parents: f58c13a
Author: Randy Gelhausen <rgelhau@gmail.com>
Authored: Sat Sep 26 14:57:15 2015 -0400
Committer: Damien Corneau <corneadoug@gmail.com>
Committed: Tue Sep 29 17:28:11 2015 +0900

----------------------------------------------------------------------
 zeppelin-web/test/karma.conf.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/9b198889/zeppelin-web/test/karma.conf.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/test/karma.conf.js b/zeppelin-web/test/karma.conf.js
index d76f72c..ce72b7c 100644
--- a/zeppelin-web/test/karma.conf.js
+++ b/zeppelin-web/test/karma.conf.js
@@ -66,7 +66,7 @@ module.exports = function(config) {
     exclude: [],
 
     // web server port
-    port: 8080,
+    port: 9002,
 
     // Start these browsers, currently available:
     // - Chrome


Mime
View raw message