zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject incubator-zeppelin git commit: Show line number overide the paragraph title
Date Sat, 15 Aug 2015 05:37:10 GMT
Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master 04b2f0b74 -> c2f9a0174


Show line number overide the paragraph title

Show line number was calling ```commitParagraph``` with the wrong parameter as title which
result in losing the title when hide\show numbers
![selection_014](https://cloud.githubusercontent.com/assets/2227083/9260817/d0aa99be-4212-11e5-9970-8d9995e15fbc.png)
Showing the numbers delete the title
![selection_015](https://cloud.githubusercontent.com/assets/2227083/9260818/d3131244-4212-11e5-981f-2726a22e313c.png)

Author: cto <goi.cto@gmail.com>

Closes #210 from eranwitkon/master and squashes the following commits:

c867131 [cto] Show line number overide the paragraph title


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/c2f9a017
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/c2f9a017
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/c2f9a017

Branch: refs/heads/master
Commit: c2f9a01740bcfe5d613bd72b26ad7d78e4321dc3
Parents: 04b2f0b
Author: cto <goi.cto@gmail.com>
Authored: Thu Aug 13 23:24:17 2015 +0300
Committer: Lee moon soo <moon@apache.org>
Committed: Fri Aug 14 22:37:08 2015 -0700

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/c2f9a017/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index 50614f5..3102869 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -357,7 +357,7 @@ angular.module('zeppelinWebApp')
     newConfig.lineNumbers = true;
     $scope.editor.renderer.setShowGutter(true);
 
-    commitParagraph($scope.paragraph.lineNumbers, $scope.paragraph.text, newConfig, newParams);
+    commitParagraph($scope.paragraph.title, $scope.paragraph.text, newConfig, newParams);
   };
 
   $scope.hideLineNumbers = function () {
@@ -366,7 +366,7 @@ angular.module('zeppelinWebApp')
     newConfig.lineNumbers = false;
     $scope.editor.renderer.setShowGutter(false);
 
-    commitParagraph($scope.paragraph.lineNumbers, $scope.paragraph.text, newConfig, newParams);
+    commitParagraph($scope.paragraph.title, $scope.paragraph.text, newConfig, newParams);
   };
 
   $scope.columnWidthClass = function(n) {


Mime
View raw message