yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-release] kingamarton commented on a change in pull request #2: [YUNIKORN-126] Add execute permission to executables
Date Mon, 18 May 2020 13:46:21 GMT

kingamarton commented on a change in pull request #2:
URL: https://github.com/apache/incubator-yunikorn-release/pull/2#discussion_r426637670



##########
File path: tools/build-release.py
##########
@@ -81,7 +81,7 @@ def setup_base_dir(release_top_path, base_path):
         org = os.path.join(release_top_path, file)
         dest = os.path.join(base_path, file)
         print("copying files: %s ===> %s" % (org, dest))
-        shutil.copyfile(org, dest)

Review comment:
       copyfile will copy only the contents, but the metadata will be skipped, so the permissions
will be skipped as well and set some default permissions.
   copy2 will copy the metadata as well. see: https://docs.python.org/2/library/shutil.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message