From dev-return-287-archive-asf-public=cust-asf.ponee.io@yunikorn.apache.org Tue Mar 17 02:51:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C1C97180647 for ; Tue, 17 Mar 2020 03:51:18 +0100 (CET) Received: (qmail 14497 invoked by uid 500); 17 Mar 2020 02:51:18 -0000 Mailing-List: contact dev-help@yunikorn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yunikorn.apache.org Delivered-To: mailing list dev@yunikorn.apache.org Received: (qmail 14485 invoked by uid 99); 17 Mar 2020 02:51:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2020 02:51:18 +0000 From: GitBox To: dev@yunikorn.apache.org Subject: [GitHub] [incubator-yunikorn-k8shim] TaoYang526 commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it Message-ID: <158441347798.17935.3142790312221913881.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 17 Mar 2020 02:51:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit TaoYang526 commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r393416294 ########## File path: deployments/admission-controllers/scheduler/admission_util.sh ########## @@ -46,6 +46,42 @@ delete_resources() { return 0 } +updateEnvVars() { + # update environment variables + while true; do + case $1 in + -e|--env) + shift + if [ -z "$1" ]; then + echo "empty argument to -e|--env flag" + exit 1 + fi + setEnvCmd=$1 + case $setEnvCmd in + *=*) + echo "Update environment variable: $setEnvCmd" + eval "$setEnvCmd" Review comment: I have tried to export the environment variables in preStart/exec/command but it seems not supported since scheduler pod failed and shown file "export xxxx=..." not exist. Also can't find any places to set the environments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org For additional commands, e-mail: dev-help@yunikorn.apache.org