From dev-return-283-archive-asf-public=cust-asf.ponee.io@yunikorn.apache.org Mon Mar 16 23:52:56 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8900F18066D for ; Tue, 17 Mar 2020 00:52:55 +0100 (CET) Received: (qmail 40831 invoked by uid 500); 16 Mar 2020 23:52:54 -0000 Mailing-List: contact dev-help@yunikorn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yunikorn.apache.org Delivered-To: mailing list dev@yunikorn.apache.org Received: (qmail 40779 invoked by uid 99); 16 Mar 2020 23:52:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2020 23:52:54 +0000 From: GitBox To: dev@yunikorn.apache.org Subject: [GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it Message-ID: <158440277480.10580.983832630461622600.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 16 Mar 2020 23:52:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yangwwei commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r393371996 ########## File path: deployments/admission-controllers/scheduler/admission_util.sh ########## @@ -46,6 +46,42 @@ delete_resources() { return 0 } +updateEnvVars() { + # update environment variables + while true; do + case $1 in + -e|--env) + shift + if [ -z "$1" ]; then + echo "empty argument to -e|--env flag" + exit 1 + fi + setEnvCmd=$1 + case $setEnvCmd in + *=*) + echo "Update environment variable: $setEnvCmd" + eval "$setEnvCmd" Review comment: why not export the environment variables here? so we don't need that in `create_resources()` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org For additional commands, e-mail: dev-help@yunikorn.apache.org