yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #109: [YUNIKORN-14] Add rest API to retrieve app/container history info
Date Thu, 26 Mar 2020 01:46:39 GMT
yangwwei commented on a change in pull request #109: [YUNIKORN-14] Add rest API to retrieve
app/container history info
URL: https://github.com/apache/incubator-yunikorn-core/pull/109#discussion_r398252203
 
 

 ##########
 File path: pkg/cache/history/history_info.go
 ##########
 @@ -0,0 +1,56 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+package history
+
+import (
+	"time"
+)
+
+var LIMIT = 144 // 10 minutes in 1 day
 
 Review comment:
   10 minutes will be too long. can we use a 1 minute interval, and keep 12 hours data?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message