yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it
Date Tue, 24 Mar 2020 04:29:14 GMT
wilfred-s commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs
before admitting it
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r396895524
 
 

 ##########
 File path: pkg/plugin/admissioncontrollers/webhook/admission_controller_test.go
 ##########
 @@ -19,6 +19,9 @@
 package main
 
 import (
+	"fmt"
+	"github.com/apache/incubator-yunikorn-k8shim/pkg/common"
+	"github.com/apache/incubator-yunikorn-k8shim/pkg/conf"
 
 Review comment:
   This does not comply with the imports formatting. Please run:
   ```golangci-lint run --new-from-rev=`git rev-parse --short=12 origin/HEAD` ```
   That should pull the origin/HEAD tag and check your change against it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message