yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-k8shim] TaoYang526 commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it
Date Tue, 17 Mar 2020 02:51:17 GMT
TaoYang526 commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs
before admitting it
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r393416294
 
 

 ##########
 File path: deployments/admission-controllers/scheduler/admission_util.sh
 ##########
 @@ -46,6 +46,42 @@ delete_resources() {
   return 0
 }
 
+updateEnvVars() {
+  # update environment variables
+  while true; do
+    case $1 in
+      -e|--env)
+        shift
+        if [ -z "$1" ]; then
+          echo "empty argument to -e|--env flag"
+          exit 1
+        fi
+        setEnvCmd=$1
+        case $setEnvCmd in
+          *=*)
+            echo "Update environment variable: $setEnvCmd"
+            eval "$setEnvCmd"
 
 Review comment:
   I have tried to export the environment variables in preStart/exec/command but it seems
not supported since scheduler pod failed and shown file "export xxxx=..." not exist. Also
can't find any places to set the environments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message