yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-k8shim] TaoYang526 commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it
Date Tue, 17 Mar 2020 02:46:46 GMT
TaoYang526 commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs
before admitting it
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r393415259
 
 

 ##########
 File path: helm-charts/yunikorn/templates/deployment.yaml
 ##########
 @@ -36,7 +36,7 @@ spec:
           lifecycle:
               postStart:
                 exec:
-                  command: ["/bin/sh", "/admission_util.sh", "create"]
+                  command: ["/bin/sh", "/admission_util.sh", "create", "--env", "NAMESPACE={{
.Release.Namespace }}"]
 
 Review comment:
   I have tested this via calling command `helm install ./yunikorn --generate-name` , the
result seems same as the command with `--namespace default`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message