yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it
Date Mon, 16 Mar 2020 23:52:54 GMT
yangwwei commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs
before admitting it
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r393371996
 
 

 ##########
 File path: deployments/admission-controllers/scheduler/admission_util.sh
 ##########
 @@ -46,6 +46,42 @@ delete_resources() {
   return 0
 }
 
+updateEnvVars() {
+  # update environment variables
+  while true; do
+    case $1 in
+      -e|--env)
+        shift
+        if [ -z "$1" ]; then
+          echo "empty argument to -e|--env flag"
+          exit 1
+        fi
+        setEnvCmd=$1
+        case $setEnvCmd in
+          *=*)
+            echo "Update environment variable: $setEnvCmd"
+            eval "$setEnvCmd"
 
 Review comment:
   why not export the environment variables here? 
   so we don't need that in `create_resources()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message