From dev-return-135-archive-asf-public=cust-asf.ponee.io@yunikorn.apache.org Tue Feb 25 01:16:01 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C985B1802C7 for ; Tue, 25 Feb 2020 02:16:00 +0100 (CET) Received: (qmail 86114 invoked by uid 500); 25 Feb 2020 01:16:00 -0000 Mailing-List: contact dev-help@yunikorn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yunikorn.apache.org Delivered-To: mailing list dev@yunikorn.apache.org Received: (qmail 86102 invoked by uid 99); 25 Feb 2020 01:16:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2020 01:16:00 +0000 From: GitBox To: dev@yunikorn.apache.org Subject: [GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #72: Add ability to support 3rd party K8s operator integration Message-ID: <158259336002.27369.12365213713441216921.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 25 Feb 2020 01:16:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit wilfred-s commented on a change in pull request #72: Add ability to support 3rd party K8s operator integration URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/72#discussion_r383608056 ########## File path: pkg/appmgmt/appmgmt_recovery_test.go ########## @@ -118,6 +121,6 @@ func (ma *mockedAppManager) ListApplications() (map[string]interfaces.Applicatio return apps, nil } -func (ma *mockedAppManager) GetExistingAllocation(pod *v1.Pod) (*si.Allocation, bool) { - return nil, false +func (ma *mockedAppManager) GetExistingAllocation(pod *v1.Pod) *si.Allocation { + return nil } Review comment: minor: missing new line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org For additional commands, e-mail: dev-help@yunikorn.apache.org