From dev-return-39-archive-asf-public=cust-asf.ponee.io@yunikorn.apache.org Wed Feb 19 06:57:33 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 433B7180674 for ; Wed, 19 Feb 2020 07:57:33 +0100 (CET) Received: (qmail 201 invoked by uid 500); 19 Feb 2020 06:57:32 -0000 Mailing-List: contact dev-help@yunikorn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@yunikorn.apache.org Delivered-To: mailing list dev@yunikorn.apache.org Received: (qmail 174 invoked by uid 99); 19 Feb 2020 06:57:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Feb 2020 06:57:32 +0000 From: GitBox To: dev@yunikorn.apache.org Subject: [GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #77: Recovery times out if the cluster initially has no nodes Message-ID: <158209545244.29981.7170516131243453146.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 19 Feb 2020 06:57:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit wilfred-s commented on a change in pull request #77: Recovery times out if the cluster initially has no nodes URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/77#discussion_r381106233 ########## File path: pkg/common/resource.go ########## @@ -159,8 +159,9 @@ func CreateUpdateRequestForNewNode(node Node) si.UpdateRequest { func CreateUpdateRequestForUpdatedNode(node Node) si.UpdateRequest { // Currently only includes resource in the update request nodeInfo := &si.UpdateNodeInfo{ - NodeID: node.name, - SchedulableResource: node.resource, + NodeID: node.name, + Attributes: make(map[string]string), Review comment: This code has been the same for a long time and is only called within the mock scheduler (test only) Currently without this change I do not see a nil pointer in the tests. Please explain how this caused a nil pointer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org For additional commands, e-mail: dev-help@yunikorn.apache.org