yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #72: Add ability to support 3rd party K8s operator integration
Date Fri, 21 Feb 2020 23:27:36 GMT
yangwwei commented on a change in pull request #72: Add ability to support 3rd party K8s operator
integration
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/72#discussion_r382852439
 
 

 ##########
 File path: pkg/appmgmt/interfaces/appmgr.go
 ##########
 @@ -0,0 +1,45 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+package interfaces
+
+// a common interface for app management service
+// an app management service monitors the lifecycle of applications,
+// it is responsible for reporting application status to the scheduler,
+// that helps the scheduler to manage the application lifecycle natively.
+type AppManager interface {
+	// the name of this application service
+	// this info is exposed to the scheduler so we know what kind of apps
+	// the scheduler is able to supervise.
+	Name() string
+
+	// if the service needs to init any objects, this is the place
+	// the initialization of the service must not start any of go routines,
+	// this will be called before starting the service.
+	ServiceInit() error
+
+	// if the service has some internal stuff to run, this is the place to run them
+	// usually if an application is defined as K8s CRD, the operator service needs
+	// to watch on these CRD events. the CRD informers can be launched here.
+	// some implementation may not need to implement this.
+	Start() error
+
+	// if there is some go routines running in start, properly stop them while
+	// the stop() function is called.
+	Stop() error
 
 Review comment:
   makes sense, fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message