yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #72: Add ability to support 3rd party K8s operator integration
Date Fri, 21 Feb 2020 19:56:49 GMT
yangwwei commented on a change in pull request #72: Add ability to support 3rd party K8s operator
integration
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/72#discussion_r382777495
 
 

 ##########
 File path: pkg/appmgmt/interfaces/recoverable.go
 ##########
 @@ -0,0 +1,41 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+package interfaces
+
+import (
+	"github.com/apache/incubator-yunikorn-scheduler-interface/lib/go/si"
+	v1 "k8s.io/api/core/v1"
+)
+
+// recoverable interface defines a certain type of app that can be recovered upon scheduler'
restart
+// each app manager needs to implement this interface in order to support fault recovery
+type Recoverable interface {
+	// list applications returns all existing applications known to this app manager.
+	// why we need this?
+	// the scheduler is stateless, all states are maintained just in memory,
+	// so each time when scheduler restarts, it needs to recover apps and nodes states from
scratch.
+	// nodes state will be taken care of by the scheduler itself, however for apps state recovery,
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message