yunikorn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #77: Recovery times out if the cluster initially has no nodes
Date Wed, 19 Feb 2020 06:57:32 GMT
wilfred-s commented on a change in pull request #77: Recovery times out if the cluster initially
has no nodes
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/77#discussion_r381106233
 
 

 ##########
 File path: pkg/common/resource.go
 ##########
 @@ -159,8 +159,9 @@ func CreateUpdateRequestForNewNode(node Node) si.UpdateRequest {
 func CreateUpdateRequestForUpdatedNode(node Node) si.UpdateRequest {
 	// Currently only includes resource in the update request
 	nodeInfo := &si.UpdateNodeInfo{
-		NodeID:              node.name,
-		SchedulableResource: node.resource,
+		NodeID:               node.name,
+		Attributes:           make(map[string]string),
 
 Review comment:
   This code has been the same for a long time and is only called within the mock scheduler
(test only)
   Currently without this change I do not see a nil pointer in the tests.
   
   Please explain how this caused a nil pointer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


Mime
View raw message