yetus-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bus...@apache.org
Subject yetus git commit: YETUS-471 Add possibility to disable the Findbugs java source folder check
Date Tue, 10 Jan 2017 16:45:28 GMT
Repository: yetus
Updated Branches:
  refs/heads/master 1d7ec1925 -> 7f58bf925


YETUS-471 Add possibility to disable the Findbugs java source folder check

Signed-off-by: sacharya <suraj.spa@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/yetus/repo
Commit: http://git-wip-us.apache.org/repos/asf/yetus/commit/7f58bf92
Tree: http://git-wip-us.apache.org/repos/asf/yetus/tree/7f58bf92
Diff: http://git-wip-us.apache.org/repos/asf/yetus/diff/7f58bf92

Branch: refs/heads/master
Commit: 7f58bf925663c0650fee83ad6135ec60507589ad
Parents: 1d7ec19
Author: Peter Vary <pvary@cloudera.com>
Authored: Wed Nov 30 17:48:33 2016 +0100
Committer: Sean Busbey <busbey@apache.org>
Committed: Tue Jan 10 10:44:37 2017 -0600

----------------------------------------------------------------------
 precommit/test-patch.d/findbugs.sh | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/yetus/blob/7f58bf92/precommit/test-patch.d/findbugs.sh
----------------------------------------------------------------------
diff --git a/precommit/test-patch.d/findbugs.sh b/precommit/test-patch.d/findbugs.sh
index aaefd4f..84a807b 100755
--- a/precommit/test-patch.d/findbugs.sh
+++ b/precommit/test-patch.d/findbugs.sh
@@ -17,6 +17,7 @@
 
 FINDBUGS_HOME=${FINDBUGS_HOME:-}
 FINDBUGS_WARNINGS_FAIL_PRECHECK=false
+FINDBUGS_SKIP_MAVEN_SOURCE_CHECK=false
 
 add_test_type findbugs
 
@@ -24,6 +25,7 @@ function findbugs_usage
 {
   yetus_add_option "--findbugs-home=<path>" "Findbugs home directory (default \${FINDBUGS_HOME})"
   yetus_add_option "--findbugs-strict-precheck" "If there are Findbugs warnings during precheck,
fail"
+  yetus_add_option "--findbugs-skip-maven-source-check" "If the buildtool is maven, then
skip the source check and run Findbugs for every module"
 }
 
 function findbugs_parse_args
@@ -38,6 +40,9 @@ function findbugs_parse_args
     --findbugs-strict-precheck)
       FINDBUGS_WARNINGS_FAIL_PRECHECK=true
     ;;
+    --findbugs-skip-maven-source-check)
+      FINDBUGS_SKIP_MAVEN_SOURCE_CHECK=true
+    ;;
     esac
   done
 }
@@ -148,7 +153,7 @@ function findbugs_runner
 
   # strip out any modules that aren't actually java modules
   # this can save a lot of time during testing
-  if [[ "${BUILDTOOL}" = maven ]]; then
+  if [[ "${BUILDTOOL}" = maven && ${FINDBUGS_SKIP_MAVEN_SOURCE_CHECK} == false ]];
then
     findbugs_maven_skipper
   fi
 


Mime
View raw message