xmlgraphics-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominik Stadler (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (XGC-72) [PATCH] Improve exception handling when loading classpath resources fails
Date Wed, 24 Jun 2015 11:51:04 GMT

     [ https://issues.apache.org/jira/browse/XGC-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dominik Stadler updated XGC-72:
-------------------------------
    Description: 
I had one invalid .jar file where signing information was not correct. When calling ClasspathResource.loadManifests(),
via ClasspathResource.getInstance(), it correctly fails with a "java.lang.SecurityException:
Invalid signature file digest for Manifest main attributes", however it does not tell me which
actual jar-file could not be loaded.

Please enhance exception handling in that method so that it reports which jar-file failed,
e.g. 

--- ClasspathResource.java      2010-07-02 14:04:28.000000000 +0200
+++ ClasspathResource.java.new  2012-08-09 08:20:21.428843500 +0200
@@ -138,6 +138,8 @@
                                 addToMapping(contentType, name, classLoader);
                             }
                         }
+                    } catch (SecurityException se) {
+                       throw new SecurityException("While handling " + u, se);
                     } catch (IOException io) {
                         // TODO: Log.
                     }

  was:
I had one invalid .jar file where signing information was not correct. XML Graphics Commons


When calling ClasspathResource.loadManifests(), via ClasspathResource.getInstance(), it correctly
fails with a "java.lang.SecurityException: Invalid signature file digest for Manifest main
attributes", however it does not tell me which actual jar-file could not be loaded.

Please enhance exception handling in that method so that it reports which jar-file failed,
e.g. 

--- ClasspathResource.java      2010-07-02 14:04:28.000000000 +0200
+++ ClasspathResource.java.new  2012-08-09 08:20:21.428843500 +0200
@@ -138,6 +138,8 @@
                                 addToMapping(contentType, name, classLoader);
                             }
                         }
+                    } catch (SecurityException se) {
+                       throw new SecurityException("While handling " + u, se);
                     } catch (IOException io) {
                         // TODO: Log.
                     }


> [PATCH] Improve exception handling when loading classpath resources fails
> -------------------------------------------------------------------------
>
>                 Key: XGC-72
>                 URL: https://issues.apache.org/jira/browse/XGC-72
>             Project: XMLGraphicsCommons
>          Issue Type: Bug
>          Components: utilities
>    Affects Versions: 1.4
>         Environment: Operating System: All
> Platform: PC
>            Reporter: Dominik Stadler
>            Assignee: XML Graphics Project Mailing List
>
> I had one invalid .jar file where signing information was not correct. When calling ClasspathResource.loadManifests(),
via ClasspathResource.getInstance(), it correctly fails with a "java.lang.SecurityException:
Invalid signature file digest for Manifest main attributes", however it does not tell me which
actual jar-file could not be loaded.
> Please enhance exception handling in that method so that it reports which jar-file failed,
e.g. 
> --- ClasspathResource.java      2010-07-02 14:04:28.000000000 +0200
> +++ ClasspathResource.java.new  2012-08-09 08:20:21.428843500 +0200
> @@ -138,6 +138,8 @@
>                                  addToMapping(contentType, name, classLoader);
>                              }
>                          }
> +                    } catch (SecurityException se) {
> +                       throw new SecurityException("While handling " + u, se);
>                      } catch (IOException io) {
>                          // TODO: Log.
>                      }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org


Mime
View raw message