Return-Path: X-Original-To: apmail-xmlgraphics-general-archive@www.apache.org Delivered-To: apmail-xmlgraphics-general-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 552DAD8D3 for ; Tue, 9 Oct 2012 14:06:29 +0000 (UTC) Received: (qmail 84290 invoked by uid 500); 9 Oct 2012 14:06:28 -0000 Mailing-List: contact general-help@xmlgraphics.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@xmlgraphics.apache.org Delivered-To: mailing list general@xmlgraphics.apache.org Received: (qmail 84281 invoked by uid 99); 9 Oct 2012 14:06:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2012 14:06:28 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.220.182] (HELO mail-vc0-f182.google.com) (209.85.220.182) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2012 14:06:23 +0000 Received: by mail-vc0-f182.google.com with SMTP id fw7so11531699vcb.27 for ; Tue, 09 Oct 2012 07:05:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:x-gm-message-state; bh=kAlKvErzWx9F/vuRtpphSyTJLiNazom9P45q8Zcb1bY=; b=MUp1zpCL1TqD6N+JKq62mHnzU9gi1QqWhIB8DtmiqC/00EPpwqRKrnTkfIwQAWNk4y FVgD/9HZSoxke1q/H6B5xg56W4YhzZLex7aLeCMpin7LmC//wDO3LBMfMwwewWXkGsvg 7tY9mSy9/b4vPYrI31T7AnVppPGe01bbRV+aIX2zAIdGE2Tskios82WeNxFiP0PtGR+t PpLHWZCq222TcRCCdYzRcH6jifqBR0y9b2HWR946AN55Mp4//AExBZ3X/urstkFk//ch rImfwzkAhAYVIeW3BRIhEf7uqRkPgU8fOVCI0pNzkN2+4o0E4J/vMXnyXatlR0otL23D W2/A== Received: by 10.52.19.109 with SMTP id d13mr9705294vde.27.1349791559339; Tue, 09 Oct 2012 07:05:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.66.201 with HTTP; Tue, 9 Oct 2012 07:05:39 -0700 (PDT) In-Reply-To: <20121009111625.5F45.60BA733C@jeremias-maerki.ch> References: <20121008160216.C1BD.60BA733C@jeremias-maerki.ch> <20121009111625.5F45.60BA733C@jeremias-maerki.ch> From: Glenn Adams Date: Tue, 9 Oct 2012 22:05:39 +0800 Message-ID: Subject: Re: [VOTE] XGC 1.5 and FOP 1.1 Releases To: general@xmlgraphics.apache.org Content-Type: multipart/alternative; boundary=bcaec501c1406a4e2504cba0d607 X-Gm-Message-State: ALoCoQnAJQrBDzFwrFeZcUbU3C8zbX03lnLUqzb9S4yk0Np2T+H93TCSCyXKDvDeC+6fs0O2qNoM X-Virus-Checked: Checked by ClamAV on apache.org --bcaec501c1406a4e2504cba0d607 Content-Type: text/plain; charset=UTF-8 Thanks! I will take this as you have completed your changes to your satisfaction, and perhaps can vote positively for a release. I will generate new images and update my vote request in the next few days (I happen to be traveling tomorrow so it will take me a little while to do this). G. On Tue, Oct 9, 2012 at 5:16 PM, Jeremias Maerki wrote: > Done: > http://svn.apache.org/viewvc?rev=1395896&view=rev > http://svn.apache.org/viewvc?rev=1395925&view=rev > > Turns out that the ImageUtil.getInputStream() case doesn't apply to the > 1.5 branch. This was done after the branching. > > Thanks for your patience, > Jeremias Maerki > > > On 09.10.2012 06:51:32 Glenn Adams wrote: > > Jeremias, please go ahead and make these changes on the appropriate > > branches, i.e.: > > > > > https://svn.apache.org/repos/asf/xmlgraphics/commons/branches/commons-1_5 > > https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/fop-1_1 > > > > Then I'll generate new images along with Vincent's suggestions and start > a > > new vote. > > > > On Mon, Oct 8, 2012 at 10:02 PM, Jeremias Maerki >wrote: > > > > > I'm happy to do the changes myself if nobody objects: > > > 1. Restore Glyphs.MAC_GLYPH_NAMES and deprecate it. > > > 2. Restore ImageUtil.getInputStream() and deprecate it. > > > 3. Cherry-pick the bugfix for the font auto-detection from trunk into > > > the 1.1 branch. > > > > > > As for "necessary": it's not if you always upgrade FOP.jar alongside > > > XGC.jar. But that may not always be the case. It's also difficult for > > > people to know which JAR works with which other JAR. I keep hearing > > > things like: which PDF Plug-in JAR do I have to use when I have FOP > 1.0? > > > And stuff like that. Also, XGC was intended to be usable and useful > > > without FOP. At any rate, the above changes restore full > > > backwards-compatibility of XGC 1.5 with XGC 1.0 to 1.4. And they will > > > avoid trouble for people using font auto-detection. > > > > > > Jeremias Maerki > > > > > > > > > On 08.10.2012 14:52:26 Glenn Adams wrote: > > > > On Mon, Oct 8, 2012 at 4:37 PM, Jeremias Maerki < > dev@jeremias-maerki.ch > > > >wrote: > > > > > > > > > I don't think these changes constitute substantive changes. They > do not > > > > > add new functionality or otherwise create a significant risk for > > > > > instability. They are merely bugfixes. The major motivation for > fixing > > > > > these IMO is in making everyone's life easier: Users will download > FOP > > > > > 1.1 and run into font auto-detection problems and others will have > to > > > > > help them. > > > > > > > > > > > > > It's a matter of degree. It is substantive in the sense that it is a > code > > > > change [1]. It is also true that it is a very trivial change, and one > > > that > > > > I'm completely fine with making at this stage. > > > > > > > > Is this change sufficient to address your concerns about the > usability of > > > > 1.1? Do you also believe that a reversion to a change on > > > Glyphs.MAC_GLYPH_NAMES > > > > is necessary? If so, could you provide a minimal patch that makes > what > > > you > > > > believe is needed? > > > > > > > > If others do not object, then I could apply [1] and this additional > patch > > > > and upload a new set of images. > > > > > > > > [1] > > > > > > > > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFile.java?r1=1356456&r2=1356455&pathrev=1356456 > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org > > > For additional commands, e-mail: general-help@xmlgraphics.apache.org > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org > For additional commands, e-mail: general-help@xmlgraphics.apache.org > > --bcaec501c1406a4e2504cba0d607--