xmlgraphics-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 50497] [PATCH] Support rdf:resource attributes in XMP
Date Tue, 10 Apr 2012 19:06:21 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=50497

Glenn Adams <gadams@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Glenn Adams <gadams@apache.org> 2012-04-10 19:06:21 UTC ---
patch landed at http://svn.apache.org/viewvc?rev=1311929&view=rev

n.b. as supplied, the patch produced a regression in junit tests, specifically
XMPParserTest.testParseEmptyValues(), which i fixed by ensuring res != null in
XMPHandler changes:

                        if ( res != null ) {
                            try {
                                URI resource = new URI(res);
                                getCurrentArray(true).add(resource);
                            } catch (URISyntaxException e) {
                                throw new SAXException("rdf:resource value is
not a well-formed URI", e);
                            }
                        }

it would be nice if you could submit an additional patch that extends
o.a.x.xmp.XMPParserTest to test the new functionality added by your patch

thanks brian!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org


Mime
View raw message