Mailing-List: contact general-help@xmlgraphics.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@xmlgraphics.apache.org
From: bugzilla@apache.org
To: general@xmlgraphics.apache.org
Subject: DO NOT REPLY [Bug 51465] New: Significant slowdown in PNG and TIFF
 processing with xmlgraphics 1.4
Date: Sat, 02 Jul 2011 12:05:23 +0000
Message-ID: <bug-51465-45363@https.issues.apache.org/bugzilla/>
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

https://issues.apache.org/bugzilla/show_bug.cgi?id=3D51465

             Bug #: 51465
           Summary: Significant slowdown in PNG and TIFF processing with
                    xmlgraphics 1.4
           Product: XMLGraphicsCommons
           Version: 1.4
          Platform: PC
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Image codecs
        AssignedTo: general@xmlgraphics.apache.org
        ReportedBy: patches@portaildulibre.fr
    Classification: Unclassified


Created attachment 27243
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=3D27243
Profiler

Hello,=20
I=E2=80=99m using fop 1.0 (xmlgraphics 1.4) to generate PDF, I noticed that=
 PDF
generation with PNG or TIF image is 7 times longer.=20
The problem doesn't appear in the version 1.3 of xmlgraphics.


The problem seems to come from color model associated with the image.
* if is_sRGB_stdStale =3D true then getRBG method is very fast
* if is_sRGB_stdStale =3D false then getRBG  is slow because the treatment =
is
delegated to ICC_ColorSpace.toRGB

The color model is correct, but it is modified by the class
org.apache.xmlgraphics.image.loader.impl.imageio.ImageLoaderImageIO
by the following code :=20
            if (providerIgnoresICC && cm instanceof ComponentColorModel) {
                // Apply ICC Profile to Image by creating a new image with a
new color model.
                ICC_Profile iccProf =3D tryToExctractICCProfile(iiometa);
                if (iccProf !=3D null) {
                    ColorModel cm2 =3D new ComponentColorModel(
                            new ICC_ColorSpace(iccProf), cm.hasAlpha(), cm
                                    .isAlphaPremultiplied(), cm
                                    .getTransparency(), cm.getTransferType(=
));
                    WritableRaster wr =3D Raster.createWritableRaster(image=
Data
                            .getSampleModel(), null);
                    imageData.copyData(wr);
                    BufferedImage bi =3D new BufferedImage(cm2, wr, cm2
                            .isAlphaPremultiplied(), null);
                    imageData =3D bi;
                    cm =3D cm2;

I removed this code and it works fine now, but it's dirty. What's the impac=
t ?

Until a fix, best regards.

--=20
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=3De=
mail
------- You are receiving this mail because: -------
You are the assignee for the bug.=

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org