xmlgraphics-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit, X and Y res, and Rows per Strip
Date Mon, 31 Jan 2011 23:19:06 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657

--- Comment #4 from Joshua Marquart <joshua.marquart@firstdata.com> 2011-01-31 18:19:02
EST ---
--
Regarding TIFFImageDecoder:

I can certainly create an enum in writer if you like.
I originally placed the value constants in the TIFFImageDecoder class to
persist alongside the name constant they are used with,
TiffImageDecoder.TIFF_RESOLUTION_UNIT.  Figured they might be referred-to
elsewhere in the codebase, but have not yet looked.

I do see now that TIFFImageDecoder extends ImageDecoderImpl, and agree this
might not be the best place.

--
Regarding RowsPerStrip:

With ImageWriterParams not being page-specific, as is the case with multi-paged
TIFF files, RowsPerStrip set to image height would need to vary on a per-page
basis and might not be able to be set until the image is rendered, as the value
might not be known.

A different solution that I am going to submit a patch for will have the
following changes to ImageWriterParams:

* VARIABLE rowsPerStrip is an int with standard get/set methods.  Defaults to
1.
* METHOD void setSingleStrip(boolean) method - true sets to -1, false sets to
1.
* METHOD boolean isSingleStrip() - convenience returns true if rowsPerStrip ==
-1

--
Regarding BitsPerSample

I believe adding the "BitsPerSample" line might have been a mistake on my part,
and I'll remove it in the upcoming patch revision to this bug.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org


Mime
View raw message