xmlgraphics-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit, X and Y res, and Rows per Strip
Date Wed, 26 Jan 2011 16:55:28 GMT

--- Comment #2 from Joshua Marquart <joshua.marquart@firstdata.com> 2011-01-26 11:55:23
EST ---
Created an attachment (id=26552)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26552)
Replaces earlier attachment, use this instead.

I made a couple mistakes in my initial patch.

Differences in this patch are

1) now uses constant from TIFFImageDecoder for cm instead of arbitrary
hard-coded value 3.

2) replaced unused proposed rowsPerStrip value and new boolean
rowsPerStripOverridden with more appropriately named oneRowPerStrip boolean.

3) revised hasResolution method to check both X and Y, which are both set in
setResolution and their own individual methods.

4) added javadoc comments to many methods that were not commented; my bad.

1) replaced call to isRowsPerStripOverridden with call to NOT isOneRowPerStrip

2) Consolidated identical boolean checks.

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org

View raw message