Return-Path: 
 <general-return-1474-apmail-xmlgraphics-general-archive=www.apache.org@xmlgraphics.apache.org>
Delivered-To: apmail-xmlgraphics-general-archive@www.apache.org
Received: (qmail 6050 invoked from network); 3 Nov 2010 20:32:15 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 3 Nov 2010 20:32:15 -0000
Received: (qmail 78635 invoked by uid 500); 3 Nov 2010 20:32:45 -0000
Mailing-List: contact general-help@xmlgraphics.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:general-help@xmlgraphics.apache.org>
List-Unsubscribe: <mailto:general-unsubscribe@xmlgraphics.apache.org>
List-Post: <mailto:general@xmlgraphics.apache.org>
List-Id: <general.xmlgraphics.apache.org>
Reply-To: general@xmlgraphics.apache.org
Delivered-To: mailing list general@xmlgraphics.apache.org
Received: (qmail 78621 invoked by uid 99); 3 Nov 2010 20:32:45 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Nov 2010 20:32:45 +0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of vhennebert@gmail.com
 designates 74.125.82.52 as permitted sender)
Received: from [74.125.82.52] (HELO mail-ww0-f52.google.com) (74.125.82.52)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Nov 2010 20:32:37 +0000
Received: by wwa36 with SMTP id 36so1181555wwa.21
        for <general@xmlgraphics.apache.org>;
 Wed, 03 Nov 2010 13:32:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:message-id:date:from
         :user-agent:mime-version:to:subject:references:in-reply-to
         :x-enigmail-version:content-type:content-transfer-encoding;
        bh=cl0CXDOxdSTzWFaiOiaAuTaRarE/1Wl5iq+I0JoC9hw=;
        b=OQ/Kq3jiCxrvADqxGLpse06KVjBkfQrEhxxA4w0ukuidRgx2XNxg0hTVE0Tbe6ruL4
         9HJsVNucoLbhkvV7wxVVMEIvTuAtEYawqiS7+FT44Gwjq75dUCpNRiuFTcSk1nKe/hK/
         a1GqWxHApw7t0ehYmvmul3tyNwxwe7EdwoSDc=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=JVZP1SI8NcXcWgPwt4CssORGplsObUFrnOvHbK6/bgk8lKsOCVhfQw042TGX5GTGIp
         PfPKuWi8COCR//NDlo7Sf2hIZhyChRF0Dc0x6Ye8voCWlf5Z0Z+d+MkwyZL4bqiiIhOb
         XR4yc705nbOqoR2SRckjzwXfHjnH0ax0eB87U=
Received: by 10.216.56.65 with SMTP id l43mr902374wec.113.1288816335690;
        Wed, 03 Nov 2010 13:32:15 -0700 (PDT)
Received: from [192.168.3.73] (uk.thunderhead.com [193.195.216.250])
        by mx.google.com with ESMTPS id f31sm5886573wej.15.2010.11.03.13.32.13
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Wed, 03 Nov 2010 13:32:13 -0700 (PDT)
Message-ID: <4CD1C6D2.3040400@gmail.com>
Date: Wed, 03 Nov 2010 20:32:18 +0000
From: Vincent Hennebert <vhennebert@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10
MIME-Version: 1.0
To: general@xmlgraphics.apache.org
Subject: Re: [VOTE] Merge XGC color branch into Trunk
References: <20101028102801.42DF.60BA733C@jeremias-maerki.ch>
 <4CCF231A.8020709@gmail.com>
 <20101103083043.982D.60BA733C@jeremias-maerki.ch>
In-Reply-To: <20101103083043.982D.60BA733C@jeremias-maerki.ch>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/11/10 07:44, Jeremias Maerki wrote:
> On 01.11.2010 21:29:14 Vincent Hennebert wrote:
<snip/>
>>   • unimplemented methods should really throw an
>>     UnsupportedOperationException or be removed altogether. Their
>>     behaviour is likely to change once they are properly implemented,
>>     introducing regressions. Putting a comment in the Javadoc is not
>>     enough, especially since those methods can silently be called by
>>     intendedToRGB
> 
> I guess it makes sense to make the methods private as long as they are
> not used. Anyway, throwing UnsupportedOperationException doesn't work in
> this case. Batik or FOP would crash whenever a color profile is
> encountered that has a rendering intent that is not implemented. The
> implemented way ensures that the user gets at least an approximate
> result.

Whether an approximate result is preferable to an exception or not is
a ‘business’ decision that I can’t make because I don’t know the
underlying field well. What is the user likely to prefer? How acceptable
is the fallback? If throwing an exception is impractical, is a warning
desirable? Or is it likely to produce too much noise?

Making the methods private seems to make sense indeed.


<snip/>

Vincent

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org