xmlgraphics-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremias Maerki <...@jeremias-maerki.ch>
Subject Re: svn commit: r979567 - in /xmlgraphics/commons/trunk: src/java/org/apache/xmlgraphics/image/loader/impl/PreloaderTIFF.java status.xml
Date Wed, 28 Jul 2010 05:43:06 GMT
On 27.07.2010 17:02:12 Vincent Hennebert wrote:
> Jeremias Maerki wrote:
> > Hi Vincent
> > 
> > 
> > On 27.07.2010 12:56:42 Vincent Hennebert wrote:
> >> Hi,
> >>
> >>> Author: jeremias
> >>> Date: Tue Jul 27 07:50:40 2010
> >>> New Revision: 979567
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=979567&view=rev
> >>> Log:
> >>> Fix for TIFFs which report zero as their resolution. This resulted in an
exception.
> >>> Modified: 
> >>> xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/image/loader/impl/PreloaderTIFF.java
> >>> ==============================================================================
> >>> @@ -127,7 +127,10 @@ public class PreloaderTIFF extends Abstr
> >>>                      xRes = fldx.getAsFloat(0);
> >>>                      yRes = fldy.getAsFloat(0);
> >>>                  }
> >>> -                if (unit == 2) {
> >>> +                if (xRes == 0 || yRes == 0) {
> >>> +                    //Some TIFFs may report 0 here which would lead to
problems
> >> Isn’t it a degenerate case that the user wants to be made aware of?
> > 
> > Not IMO. The users can always size the images to their wishes.
> 
> So that’s done by setting resolution to 0?

No, what I mean is that people can use the properties on
fo:external-graphic and svg:image to scale the images to their wishes. A
missing resolution is just a fact of life in some very rare cases (for
TIFF).

> >> Also, what if xRes == 0 but yRes != 0 or vice versa?
> > 
> > That's a very interesting question...
> 
> Ok, so I assume my question was actually stupid. Might well be as
> I don’t know anything about TIFF. I thought that maybe the non-null
> resolution could be used for both axes, instead of relying on an
> external arbitrary value. But I suppose that doesn’t matter.

There are generally no stupid questions. But this one was kind of
academic which is why I reacted like this. Of course, we could handle
these two cases, too, but even the case I've fixed happens very rarely.
I estimate a probability of less than 0.0001 that this special case
you raised ever happens so rather than further complicating the code, I
chose a compromise that nobody is likely to ever stumble on in practice,
only when someone is reading the code. The resolution is only a hint.
Most people will scale their images anyway in which case the resolution
doesn't matter at all.


Jeremias Maerki


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org


Mime
View raw message