xmlgraphics-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49339] [PATCH] Incorrect AffineTransform in PSGenerator state due to AbstractPSDocumentGraphics2D.startPage method
Date Sun, 30 May 2010 16:25:29 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49339

Julien Aymé <julien.ayme@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #4 from Julien Aymé <julien.ayme@gmail.com> 2010-05-30 12:25:26 EDT ---
Hi Jeremias,

I'm not currently at work but I think I can provide a valid use case: I've
modified the PSDocumentGraphics2D by adding some "batch" drawing.

The main pattern for the "batch" drawing, like in draw/fill(Shape) method, is:
- Save graphic state, 
- Concat matrix if required,
- Do batch drawing (mainly calls of Graphics2D fill(Shape) and drawString
methods)
with no AffineTransform change (important).
- Restore graphic state.

The use case that triggered the issue was, if I remember well:
- Define an AffineTransform (different from Identity) into the Graphics.
- Call any of the "batch" drawing defined above.

The thing is, since I already defined the matrix before calling any of the
PSDocumentGraphics2D method, it should not concat the matrix again. But my
problem was that even if I just added the matrix to the GraphicState, the
method checkTransform returned true, and the matrix was written once again.

I will check tomorrow that this use case was the right one (which triggered the
issue).

PS: Thanks for the review of all my patch ;-)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org


Mime
View raw message