Mailing-List: contact general-help@xmlgraphics.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@xmlgraphics.apache.org
Received-SPF: pass (athena.apache.org: domain of helder.magalhaes@gmail.com
 designates 74.125.78.24 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=ZRq0Ys9YY9JrhxZOGWiz+SNAwze+uloalU1h1XEEsvMDXC/v/SjYSA2pWpSKRM239J
         6xWVHzhkSA3pwRZzzJpDMVLVTHQhss/BwqyxbSAGbz3J9+kpdpRwSABX1b+X+3PSpprZ
         2NVGKu19s1hPtYt26X3Czp5LbpZLsn+6YHuVo=
MIME-Version: 1.0
In-Reply-To: <dfb113433353c8d2.4b814800@ac-rennes.fr>
References: <dfb113433353c8d2.4b814800@ac-rennes.fr>
From: =?ISO-8859-1?Q?Helder_Magalh=E3es?= <helder.magalhaes@gmail.com>
Date: Sun, 21 Feb 2010 14:06:19 +0000
Message-ID: <2a1ddf8a1002210606j5ade21abge409a6dc4a154bbd@mail.gmail.com>
Subject: Re: Patch to reduce the size of generated ps
To: general@xmlgraphics.apache.org
Cc: Calixte.Denizet@ac-rennes.fr
Content-Type: text/plain; charset=ISO-8859-1

Hi Calixte,


> I wrote the attached patch to reduce the size of ps or eps file. I added basic shortcuts to postscript commands and gave an
> access to the property clippingDisabled. With these modifications (and in using the added method disableClipping) I can divide
> by 3 the size of eps files (generated from svg).

Thanks for your contribution. I'm not a EPS expert so I'm only leaving
a couple comments, mostly cosmetic.

1. Indentation issues.
A quick review of the patch shows that, in a couple files, tabs
instead of (4) spaces were used:
 * src/java/org/apache/xmlgraphics/ps/PSProcSets.java
 * src/java/org/apache/xmlgraphics/java2d/ps/AbstractPSDocumentGraphics2D.java

2. Potential coherency improvement.
In:
> +	    gen.writeln("/f/fill ld");
> +	    gen.writeln("/S/stroke ld");
If "S" stands for "stroke", why is "f" being used for "fill"? Is it a
reserved keyword? If not, using the capitalized "F" would make things
more coherent IMO. There are also more places were this could also
apply, but I haven't reviewed the whole file... ;-)


> I'll be happy if you can push them for the next release.

As said, I'm no PostScript expert but, overall, the patch looks good
and safe to apply. :-)

It would be great if you could update your patch. ;-)


> Best regards,

Thanks,
 Helder

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org