xmlgraphics-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46583] [PATCH] PS tiling patterns implementation
Date Sat, 07 Feb 2009 11:31:25 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46583


Jeremias Maerki <jeremias@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO




--- Comment #1 from Jeremias Maerki <jeremias@apache.org>  2009-02-07 03:31:24 PST ---
Sorry for not responding earlier. Thank you for your patch. This is a nice
addition. However, before I can process your patch, can I ask you to do the
following:

- Since your patch includes new files, please fill out and send an ICLA
(Individual Contributor License Agreement, see [1] for details). Depending on
your work contract you may also need to ask your employer to consider sending
in a CCLA.

[1] http://apache.org/licenses/#clas

- Please put the same license header you find in our other source files on top
of the new files you create to clearly indicate that you are donating this to
the ASF.

- And finally, please rework the patch to make it Java 1.4 compatible. (this
point I can handle for you if you want but it would be great if you could do it
while you add the license headers)

- One note on the code while taking a quick look: You used an ArrayList for the
bounding box. Please consider using a java.awt.Rectangle instead.

I hope you understand. Thank you very much!


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org


Mime
View raw message