xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51928] New: [PATCH] Upgrade to JUnit4
Date Fri, 30 Sep 2011 13:41:00 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51928

             Bug #: 51928
           Summary: [PATCH] Upgrade to JUnit4
           Product: Fop
           Version: 1.0
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: med1985@gmail.com
    Classification: Unclassified


Created attachment 27649
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27649
Update unit tests to JUnit4

This is the eagerly anticipated upgrade of FOPs JUnit tests to JUnit4. There
are a few notable differences:
1) Tests can now be parameterized (I'll discuss this later).
2) The test outputs have less meaningful names when parameterized, the layout
engine tests used to be instantiated with the names of set as the name of the
FO used in the test. Because these have been changed to be parameterized tests,
the output is less useful. I haven't found a suitable way of changing the name
of the test for a parameterized test short of overriding the
org.junit.runners.Parameterized.

I've tried to touch as little as possible with the layout engine tests, in
terms of their reliance on the system properties being injected in. I wish to
change that in a future commit, but I think it's a logically separate issue and
I will create a separate patch for that.

The layout engine tests do need a little TLC, there seems to be a fair amount
of code duplication in that area. I'll address these at the same time as the
patch above.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message