xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Pepping <spepp...@leverkruid.eu>
Subject Re: Revision 1175754 introduces a findbugs error
Date Thu, 29 Sep 2011 08:20:07 GMT
I will fix it. It is a good habit to run findbugs.

This error means that CIDFont.getDefaultWidth() is not overwritten in
MultiByteFont, and that therefore MultiByteFont.getDefaultWidth()
returns the wrong value. Can there be a test that reveals such an
error?

Simon

On Wed, Sep 28, 2011 at 08:53:26PM +0100, mehdi houshmand wrote:
> Hi,
> 
> This is my fault, I think this was a merge conflict here, it should be
> MultiByteFont.getDefaultWidth().
> 
> My apologies.
> 
> Mehdi
> 
> On 28 September 2011 20:38, Simon Pepping <spepping@leverkruid.eu> wrote:
> > Revision 1175754 introduces a significant findbugs error:
> >
> > VERY confusing to have methods
> > org.apache.fop.fonts.MultiByteFont.getdefaultwidth() and
> > org.apache.fop.fonts.CIDFont.getDefaultWidth()
> >
> > Simon
> >

Mime
View raw message