xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pascal Sancho <pascal.san...@takoma.fr>
Subject Re: Want to contribute
Date Wed, 11 May 2011 07:11:23 GMT
Hi Darshan,

Le 09/05/2011 23:28, darshan pradhan a écrit :
> Thank you for the reply. While I was looking at old open issues that
> haven't been closed, I came across
> https://issues.apache.org/bugzilla/show_bug.cgi?id=47279 , this bug
> seems to have been fixed. I tried creating a pdf from a xml using xsl
> without specifying any font-name, and setting the font-weight to bold. I
> didn't get any warning messages form the conversion. Should I change the
> state of the bug form open to resolved?

As said in issue comments, the test case should send warnings, if this
is not the case, then the issues should remain opened.

> I wanted to test the resolved bugs as well. I saw that some have test
> cases modified as patches are applied. I wasn't sure how I can go about
> testing for the bug fixes. For instance for the patch in
> https://issues.apache.org/bugzilla/show_bug.cgi?id=50471 , should I
> create a document with a character 1F7E and see if fop runs without errors?

If such test case doesn't exist in FOP source code, you can create and
propose it as a patch (see [1]) in a new bugzilla entry (to keep track
of it).
Just 2 things:
 - when running the test-case, the issue should occur before bugfix, IE
before rev 1056518;
 - the new bug entry should be related to the #50471

[1] http://xmlgraphics.apache.org/fop/dev/index.html#patches

> Lastly, in the page
> http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests
> under the topic *Setting up the Test Suite in your favorite IDE,* I
> could not figure out how to set the system properties to control the
> test cases run in Eclipse. Could you please tell me how to do it?

I cannot help you on this topic. Someone else?

> I would really appreciate your guidance.
> 
> Thank you,
> Darshan
> 
> On 03/05/11 20:47, Glenn Adams wrote:
>> Actually, I would encourage testing closed issues, or at least those
>> issues that were resolved without creating a test data set that
>> demonstrates both the bug and the fix, and maintains non-regression.
>>
>> I have noticed a number of issues "fixed" without adding such tests,
>> which should be the norm, not the exception.
>>
>> G.
>>
>> On Tue, May 3, 2011 at 1:24 AM, Pascal Sancho <pascal.sancho@takoma.fr
>> <mailto:pascal.sancho@takoma.fr>> wrote:
>>
>>     Hi,
>>
>>     FOP is an open source project, and everybody can contribute in his own
>>     way, so you can reopen closed issues as you want if needed, and submit
>>     patches as you want.
>>
>>     That said, IMHO, apart in a company quality context, testing closed
>>     issues will not help very much (typically, an issue is closed after
>>     developer's checks, and it is often monitored by the opener who reopen
>>     it if needed)
>>     But:
>>     you can check old opened issues against FOP TRUNK, since there is no
>>     systematic checks for opened issues after each commit.
>>     You can find fixed issues that haven't been closed.
>>
>>     Le 01/05/2011 02:25, darshan a écrit :
>>     > Dear All,
>>     >
>>     > I am a post graduate student at the Australian National University
>>     > taking a course on Free and Open Source Software Development.
>>     Part of
>>     > the course requirement is to study an open source project of my
>>     choice,
>>     > make a contribution and write a report by the end of May 2011.
>>     >
>>     > I have been going through the fop site and documents and from
>>     the 'How
>>     > you can help' topic on the page
>>     > http://xmlgraphics.apache.org/fop/dev/index.html
>>     > I thought the best way I could contribute is  by testing
>>     newly-closed
>>     > issues to make sure they are truly closed. By doing this I can
>>     gradually
>>     > understand how the system works and hopefully start make more
>>     > contributions like submitting bug reports and patches.
>>     >
>>     > Can I start from the most recent fix form the page
>>     > http://xmlgraphics.apache.org/fop/changes.html#Code_FOP%20Trunk
>>     ? please
>>     > guide me as to what would be the best way of doing it and also I
>>     would
>>     > be really glad if you could suggest me any other way to
>>     contribute that
>>     > would help the project better.
>>     >
>>     > Best regards,
>>     > Darshan Pradhan
>>     > u4729733@anu.edu.au <mailto:u4729733@anu.edu.au>
>>
>>     --
>>     Pascal
>>
>>
> 

-- 
Pascal

Mime
View raw message