Mailing-List: contact fop-dev-help@xmlgraphics.apache.org; run by ezmlm
Precedence: bulk
Reply-To: fop-dev@xmlgraphics.apache.org
Received-SPF: pass (athena.apache.org: domain of adrian.cumiskey@gmail.com
 designates 66.249.92.168 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding:from;
        b=ZA64qHpqNfpQ7AnuuTFi4UT8VTuj9S4j8oGM0237I+ASYlJkjUSoGVXssu/wUYKHSk
         nn7X1454V//MhSNVxBj55hC9aTzzrShX4LYEvT3nolPVyu8d8ioaNaCjQDzkhPCUjXgk
         dl9Y5fhYk2DvI7Y6XvZBkoLRKXxRxRESmcox8=
Message-ID: <48AC228D.10401@cumiskey.com>
Date: Wed, 20 Aug 2008 14:56:29 +0100
User-Agent: Thunderbird 2.0.0.16 (X11/20080724)
MIME-Version: 1.0
To: fop-dev@xmlgraphics.apache.org
Subject: Re: svn commit: r687323 - in
 /xmlgraphics/fop/trunk/src/java/org/apache/fop/render:
 afp/AFPRenderer.java pcl/PCLRenderer.java
References: <20080820132418.DF6D3238896F@eris.apache.org>
In-Reply-To: <20080820132418.DF6D3238896F@eris.apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
From: Adrian Cumiskey <adrian.cumiskey@gmail.com>

I don't think it is Max... looks like @since 1.4.

    /**
      * Returns a <tt>Boolean</tt> instance representing the specified
      * <tt>boolean</tt> value.  If the specified <tt>boolean</tt> value
      * is <tt>true</tt>, this method returns <tt>Boolean.TRUE</tt>;
      * if it is <tt>false</tt>, this method returns <tt>Boolean.FALSE</tt>.
      * If a new <tt>Boolean</tt> instance is not required, this method
      * should generally be used in preference to the constructor
      * {@link #Boolean(boolean)}, as this method is likely to to yield
      * significantly better space and time performance.
      *
      * @param  b a boolean value.
      * @return a <tt>Boolean</tt> instance representing <tt>b</tt>.
      * @since  1.4
      */
     public static Boolean valueOf(boolean b) {
         return (b ? TRUE : FALSE);
     }

Adrian.


maxberger@apache.org wrote:
> Author: maxberger
> Date: Wed Aug 20 06:24:18 2008
> New Revision: 687323
> 
> URL: http://svn.apache.org/viewvc?rev=687323&view=rev
> Log:
> valueOf is Java 1.5+ only
> 
> Modified:
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRenderer.java
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLRenderer.java
> 
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRenderer.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRenderer.java?rev=687323&r1=687322&r2=687323&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRenderer.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRenderer.java Wed Aug 20 06:24:18 2008
> @@ -935,7 +935,7 @@
>          RendererContext context;
>          context = super.createRendererContext(x, y, width, height, foreignAttributes);
>          context.setProperty(AFPRendererContextConstants.AFP_GRAYSCALE,
> -                Boolean.valueOf(!this.colorImages));
> +                new Boolean(!this.colorImages));
>          return context;
>      }
>  
> 
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLRenderer.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLRenderer.java?rev=687323&r1=687322&r2=687323&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLRenderer.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pcl/PCLRenderer.java Wed Aug 20 06:24:18 2008
> @@ -1148,7 +1148,7 @@
>          RendererContext context = super.createRendererContext(
>                  x, y, width, height, foreignAttributes);
>          context.setProperty(PCLRendererContextConstants.PCL_COLOR_CANVAS,
> -                Boolean.valueOf(this.useColorCanvas));
> +                new Boolean(this.useColorCanvas));
>          return context;
>      }
>  
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
> 
>