xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 35940] - 1.0dev differences to 0.20.5
Date Fri, 19 Aug 2005 13:53:04 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35940>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35940





------- Additional Comments From jeremias@apache.org  2005-08-19 15:53 -------
(In reply to comment #6)
> I have finally found where the problem lies:
> 1) in the sample file there is a trailing space at the end of the centered 
text

...because the linefeed after "Result" is converted into a space character, 
AFAICT. This is because of the default values for linefeed-treatment and 
whitespace-treatment (both handled inside fo.flow.Block.handleWhiteSpace() 
during refinement). 

> 2) the sequence of elements created for a space inside centered text is 
glue - 
> penalty - glue - box - penalty - glue
> 3) the method LineLayoutManager.endSequence() removes penalty and glue 
> elements at the end of the sequence, before adding the final elements; thus, 
> the LineLM removes only the two last elements in the sub-sequence 
representing 
> a space, leaving the other 4 elements and corrupting the resulting sequence
> So, the bug could be either in 1 (there should not be a trailing space) 

No, I don't think so. I think this is white-space-collapse specified to kick 
in during area tree generation.

> or 3 
> (elements removal should be more sophisticated), or maybe in both.

Only 3 IMO.

> As white space handling is not a code section I know very well, I'm going to 
> fix the endSequence() method. :-)

Not the reason I'd have chosen, but I think it's the right place to fix it. :-)

I know white space handling pretty well by now and the linefeed that is 
converted to a space in this case seems to be correct. It seems like white-
space-collapse is the thing that is not working properly. I've also found 
something else earlier about leading spaces when white-space cannot collapse. 
I haven't fixed that problem, yet, but it's another story anyway. At any rate, 
we need good test cases to check for all the combinations. But I don't know if 
the layout engine facility is good enough to check for all the details that 
come into play here.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Mime
View raw message