Return-Path: Delivered-To: apmail-xml-fop-dev-archive@xml.apache.org Received: (qmail 17272 invoked by uid 500); 8 Jan 2003 00:28:36 -0000 Mailing-List: contact fop-dev-help@xml.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: fop-dev@xml.apache.org Delivered-To: mailing list fop-dev@xml.apache.org Received: (qmail 17261 invoked from network); 8 Jan 2003 00:28:35 -0000 Message-ID: <3E1B70BA.8090006@recalldesign.com> Date: Wed, 08 Jan 2003 10:58:42 +1030 From: Michael Gratton Organization: Recall Design User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030105 X-Accept-Language: en-au, en-gb, en, ja MIME-Version: 1.0 To: fop-dev@xml.apache.org Subject: Re: FOP Style Guide (update) References: <20030103101022.D96A.DEV.JEREMIAS@greenmail.ch> <20030107173902.F763.DEV.JEREMIAS@greenmail.ch> <3E1B7016.2010509@recalldesign.com> In-Reply-To: <3E1B7016.2010509@recalldesign.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-36.8 required=6.0 tests=IN_REP_TO,AWL version=2.31 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Michael Gratton wrote: > > Surely: > > return isEnabled(); > > is far, far better - it more clearly expresses your intent. > Err, unless you don't want to return if isEnabled() returns false.. I think I might go get that coffee now.. :( Anyway, I don't think if (isEnabled()) { return true; } is too onerous. Sun's code conventions reccomend it. /mike -- Michael Gratton Recall Design s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 --------------------------------------------------------------------- To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org For additional commands, email: fop-dev-help@xml.apache.org