Return-Path: 
 <fop-dev-return-18633-apmail-xml-fop-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-fop-dev-archive@xml.apache.org
Received: (qmail 77398 invoked by uid 500); 12 Jan 2003 03:56:43 -0000
Mailing-List: contact fop-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:fop-dev-help@xml.apache.org>
list-unsubscribe: <mailto:fop-dev-unsubscribe@xml.apache.org>
list-post: <mailto:fop-dev@xml.apache.org>
Reply-To: fop-dev@xml.apache.org
Delivered-To: mailing list fop-dev@xml.apache.org
Received: (qmail 77383 invoked from network); 12 Jan 2003 03:56:42 -0000
Date: Sun, 12 Jan 2003 14:59:36 +1100
From: Jeff Turner <jefft@apache.org>
To: fop-dev@xml.apache.org
Subject: Re: [PATCH] doc validation fix
Message-ID: <20030112035936.GB2861@expresso.localdomain>
Mail-Followup-To: fop-dev@xml.apache.org
References: <20030110144511.GA7527@expresso.localdomain>
 <20030111173109.D355.DEV.JEREMIAS@greenmail.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="LQksG6bCIzRHxTLp"
Content-Disposition: inline
In-Reply-To: <20030111173109.D355.DEV.JEREMIAS@greenmail.ch>
User-Agent: Mutt/1.4i
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

--LQksG6bCIzRHxTLp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jan 11, 2003 at 05:43:37PM +0100, Jeremias Maerki wrote:
> Hi Jeff
> 
> I've applied your patches locally. Thanks. Everything's ok with the
> first one, but with the second one I'm having problems (not your fault!):
> - I had to add adjust the inline DTD of skinconf.xml to include the role
>   attribute:
>   <!ELEMENT credit (name, url, image, width?, height?)>
>   <!ATTLIST credit role CDATA #IMPLIED>

Oops yes, sorry.  Attached is a fix with DTD mods.

> - The credit element produces a rather ugly FOP logo.

If you upgrade your Forrest, the logo won't appear[1].  The @role="pdf"
in skinconf.xml means the credit only applies to PDFs.  Earlier versions
of Forrest didn't know about this, so rather than display a broken image,
I threw in the current FOP logo.

--Jeff


[1] See http://forrestbot.cocoondev.org/sites/xml-fop/ (after applying
the patch)

> But that's probably more a FOP-internal thing. We probably need a
> customized little image for this. It should probably be something like:
> PDFs generated with
>         <logo>   F O P
> 
> Questions:
> - Does anyone have the original logo (AI, CorelDraw, SVG etc.)??? I
>   haven't found it anywhere.
> - Do we like our current logo? :-)
> 
> I've commented out Jeff's credit element for the moment and will commit
> the changes in a minute.
...

--LQksG6bCIzRHxTLp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="skinconf-credit-fix.diff"

Index: src/documentation/skinconf.xml
===================================================================
RCS file: /home/cvspublic/xml-fop/src/documentation/skinconf.xml,v
retrieving revision 1.4
diff -u -r1.4 skinconf.xml
--- src/documentation/skinconf.xml	11 Jan 2003 16:49:26 -0000	1.4
+++ src/documentation/skinconf.xml	12 Jan 2003 03:47:16 -0000
@@ -11,10 +11,14 @@
 
   <!ENTITY % links.att 'name CDATA #REQUIRED'>
   <!ENTITY % link.att 'name CDATA #REQUIRED href CDATA #REQUIRED'>
-  <!ELEMENT skinconfig (disable-search?, searchsite-domain?, searchsite-name?, project-name, project-url, project-logo, group-name?, group-url?, group-logo?, host-logo?, year?, vendor?, trail?, credits?)*>
+  <!ELEMENT skinconfig (disable-search?, searchsite-domain?, searchsite-name?,
+  project-name, project-url, project-logo, group-name?, group-url?, group-logo?,
+  host-url?, host-logo?, year?, vendor?, trail?, credits?)*>
   <!ELEMENT credits (credit*)>
-  <!ELEMENT credit (name, url, image, width?, height?)>
-  <!ATTLIST credit role CDATA #IMPLIED>
+  <!ELEMENT credit (name, url, image?, width?, height?)>
+  <!-- id uniquely identifies the tool, and role indicates its function -->
+  <!ATTLIST credit id   CDATA #IMPLIED
+                   role CDATA #IMPLIED>
   <!ELEMENT disable-search (#PCDATA)>
   <!ELEMENT searchsite-domain (#PCDATA)>
   <!ELEMENT searchsite-name (#PCDATA)>
@@ -24,6 +28,7 @@
   <!ELEMENT group-name (#PCDATA)>
   <!ELEMENT group-url (#PCDATA)>
   <!ELEMENT group-logo (#PCDATA)>
+  <!ELEMENT host-url (#PCDATA)>
   <!ELEMENT host-logo (#PCDATA)>
   <!ELEMENT year (#PCDATA)>
   <!ELEMENT vendor (#PCDATA)>
@@ -90,12 +95,12 @@
       <width>138</width>
       <height>31</height>
     </credit>-->
-    <!--credit role="pdf">
+    <credit role="pdf">
       <name>Created by: FOP 1.0dev</name>
       <url>http://xml.apache.org/fop/dev</url>
       <image>images/logo.jpg</image>
       <width>138</width>
       <height>31</height>
-    </credit-->
+    </credit>
   </credits>
 </skinconfig>


--LQksG6bCIzRHxTLp
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
--LQksG6bCIzRHxTLp--