xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Turner <je...@apache.org>
Subject Re: [PATCH] doc validation fix
Date Sun, 12 Jan 2003 03:59:36 GMT
On Sat, Jan 11, 2003 at 05:43:37PM +0100, Jeremias Maerki wrote:
> Hi Jeff
> I've applied your patches locally. Thanks. Everything's ok with the
> first one, but with the second one I'm having problems (not your fault!):
> - I had to add adjust the inline DTD of skinconf.xml to include the role
>   attribute:
>   <!ELEMENT credit (name, url, image, width?, height?)>
>   <!ATTLIST credit role CDATA #IMPLIED>

Oops yes, sorry.  Attached is a fix with DTD mods.

> - The credit element produces a rather ugly FOP logo.

If you upgrade your Forrest, the logo won't appear[1].  The @role="pdf"
in skinconf.xml means the credit only applies to PDFs.  Earlier versions
of Forrest didn't know about this, so rather than display a broken image,
I threw in the current FOP logo.


[1] See http://forrestbot.cocoondev.org/sites/xml-fop/ (after applying
the patch)

> But that's probably more a FOP-internal thing. We probably need a
> customized little image for this. It should probably be something like:
> PDFs generated with
>         <logo>   F O P
> Questions:
> - Does anyone have the original logo (AI, CorelDraw, SVG etc.)??? I
>   haven't found it anywhere.
> - Do we like our current logo? :-)
> I've commented out Jeff's credit element for the moment and will commit
> the changes in a minute.

View raw message