xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremias Maerki <dev.jerem...@greenmail.ch>
Subject Re: [PATCH] doc validation fix
Date Sat, 11 Jan 2003 16:43:37 GMT
Hi Jeff

I've applied your patches locally. Thanks. Everything's ok with the
first one, but with the second one I'm having problems (not your fault!):
- I had to add adjust the inline DTD of skinconf.xml to include the role
  attribute:
  <!ELEMENT credit (name, url, image, width?, height?)>
  <!ATTLIST credit role CDATA #IMPLIED>
- The credit element produces a rather ugly FOP logo. But that's
  probably more a FOP-internal thing. We probably need a customized
  little image for this. It should probably be something like:
        PDFs generated with
        <logo>   F O P

Questions:
- Does anyone have the original logo (AI, CorelDraw, SVG etc.)??? I
  haven't found it anywhere.
- Do we like our current logo? :-)

I've commented out Jeff's credit element for the moment and will commit
the changes in a minute.

On 10.01.2003 15:45:11 Jeff Turner wrote:
> Running 'forrest validate' on CVS head, I get:
> 
> validate-xdocs:
> /home/jeff/apache/xml/xml-fop/src/documentation/content/xdocs/design/alt.design/properties/enumerated-values.xml:211:63:
> Element type "code." must be declared.
> /home/jeff/apache/xml/xml-fop/src/documentation/content/xdocs/design/alt.design/properties/enumerated-values.xml:212:44:
> The element type "code." must be terminated by the matching end-tag
> "</code.>".
> 
> Attached patch fixes this, and cleans up enumerated-values.xml a bit.
> 
> Also, I've just modified Forrest so that the
> xml-fop/src/documentation/forrest.diff patch is no longer necessary.  To
> achieve the same effect, the second attached patch adds this to
> src/documentation/skinconf.xml:
> 
> +    <credit role="pdf">
> +      <name>Created by: FOP 1.0dev</name>
> +      <url>http://xml.apache.org/fop/dev</url>
> +      <image>images/logo.jpg</image>
> +      <width>138</width>
> +      <height>31</height>
> +    </credit>
> 
> The image, width and height fields are unused, but I put them there so
> users with pre-patched Forrests (which don't know about @role) don't get
> a broken link on the HTML front-page.


Jeremias Maerki


---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Mime
View raw message