xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremias Maerki <dev.jerem...@greenmail.ch>
Subject Re: text-decoration
Date Wed, 08 Jan 2003 15:38:16 GMT
Hi Oleg

On 08.01.2003 13:11:34 Oleg Tkachenko wrote:
> How are we going to process underline/overline etc stuff?
> It's a little bit confusing - we've got unused TextState class along with 
> TextInfo that includes text-decoration info already. Lets get rid of TextState ?
> And what about rendering, does pdf support text-decoration directly or we have 
> to draw lines as in the branch?

TextState seems to be dead. References in PageNumber, PageNumberCitation
and FOText but without any function. So remove it.

TextInfo looks better but could IMO be merged with FontState which only
hold the font name and size and a link to the FontMetrics. Anyway, I
think this merged class will be a candidate for the Flyweight pattern so
we don't generate so many TextInfo/FontState objects (one for each FObj
I think). Brings up the question of efficiently looking up existing
Flyweights, on the other side.

As far as underline/overline stuff is concerned, I like the idea of
having PrintRenderer calculate these and calling subclasses to draw the
lines (like in the branch). That makes the behaviour uniform over most
renderers (those derived from PrintRenderer).

Would it help if I started again with the PostScript renderer so code
factored out into PrintRenderer can be verified?

Jeremias Maerki


---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Mime
View raw message