Return-Path: Delivered-To: apmail-xmlgraphics-fop-commits-archive@www.apache.org Received: (qmail 66223 invoked from network); 8 May 2008 23:47:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 May 2008 23:47:06 -0000 Received: (qmail 60526 invoked by uid 500); 8 May 2008 23:47:08 -0000 Delivered-To: apmail-xmlgraphics-fop-commits-archive@xmlgraphics.apache.org Received: (qmail 60435 invoked by uid 500); 8 May 2008 23:47:08 -0000 Mailing-List: contact fop-commits-help@xmlgraphics.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: fop-dev@xmlgraphics.apache.org Delivered-To: mailing list fop-commits@xmlgraphics.apache.org Received: (qmail 60424 invoked by uid 99); 8 May 2008 23:47:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 May 2008 16:47:08 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 May 2008 23:46:31 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id BDA8B238899B; Thu, 8 May 2008 16:46:45 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r654654 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/area/IDTracker.java Date: Thu, 08 May 2008 23:46:45 -0000 To: fop-commits@xmlgraphics.apache.org From: adelmelle@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080508234645.BDA8B238899B@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: adelmelle Date: Thu May 8 16:46:45 2008 New Revision: 654654 URL: http://svn.apache.org/viewvc?rev=654654&view=rev Log: Quick-fix to avoid creating unnecessarily large ArrayLists when adding inline ids to the page Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/area/IDTracker.java Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/area/IDTracker.java URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/area/IDTracker.java?rev=654654&r1=654653&r2=654654&view=diff ============================================================================== --- xmlgraphics/fop/trunk/src/java/org/apache/fop/area/IDTracker.java (original) +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/area/IDTracker.java Thu May 8 16:46:45 2008 @@ -78,7 +78,11 @@ tryIDResolution(id, pv, pvList); } } else { - pvList.add(pv); + /* TODO: The check is a quick-fix to avoid a waste + * when adding inline-ids to the page */ + if (!pvList.contains(pv)) { + pvList.add(pv); + } } } @@ -140,7 +144,7 @@ * * @param id ID to resolve * @param pv page viewport whose ID refs to resolve - * @param List of PageViewports + * @param pvList of PageViewports */ private void tryIDResolution(String id, PageViewport pv, List pvList) { Set todo = (Set) unresolvedIDRefs.get(id); --------------------------------------------------------------------- To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org