Return-Path: Delivered-To: apmail-xmlgraphics-fop-commits-archive@www.apache.org Received: (qmail 40167 invoked from network); 21 May 2007 06:18:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 May 2007 06:18:11 -0000 Received: (qmail 2734 invoked by uid 500); 21 May 2007 06:18:17 -0000 Delivered-To: apmail-xmlgraphics-fop-commits-archive@xmlgraphics.apache.org Received: (qmail 2693 invoked by uid 500); 21 May 2007 06:18:17 -0000 Mailing-List: contact fop-commits-help@xmlgraphics.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: fop-dev@xmlgraphics.apache.org Delivered-To: mailing list fop-commits@xmlgraphics.apache.org Received: (qmail 2676 invoked by uid 99); 21 May 2007 06:18:17 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 May 2007 23:18:17 -0700 X-ASF-Spam-Status: No, hits=-99.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 May 2007 23:18:10 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 4B8421A981A; Sun, 20 May 2007 23:17:50 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r540036 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/area/Trait.java Date: Mon, 21 May 2007 06:17:49 -0000 To: fop-commits@xmlgraphics.apache.org From: jeremias@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070521061750.4B8421A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jeremias Date: Sun May 20 23:17:48 2007 New Revision: 540036 URL: http://svn.apache.org/viewvc?view=rev&rev=540036 Log: Bugzilla #42067: Fixed a possible StringIndexOutOfBoundsException. Submitted by: Paul Vinkenoog Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/area/Trait.java Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/area/Trait.java URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/area/Trait.java?view=diff&rev=540036&r1=540035&r2=540036 ============================================================================== --- xmlgraphics/fop/trunk/src/java/org/apache/fop/area/Trait.java (original) +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/area/Trait.java Sun May 20 23:17:48 2007 @@ -520,7 +520,8 @@ String[] result = {null, null}; if (attrValue != null) { int len = attrValue.length(); - if (len >= 2 && attrValue.charAt(0) == '(' && attrValue.charAt(len - 1) == ')') { + if (len >= 2 && attrValue.charAt(0) == '(' && attrValue.charAt(len - 1) == ')' + && attrValue.indexOf(',') != -1) { String value = attrValue.substring(1, len - 1); // remove brackets int delimIndex = value.indexOf(','); result[0] = value.substring(0, delimIndex).trim(); // PV key --------------------------------------------------------------------- To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org