xmlgraphics-fop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerem...@apache.org
Subject svn commit: r326547 - in /xmlgraphics/fop/branches/Temp_SpaceResolution: src/java/org/apache/fop/layoutmgr/ test/layoutengine/ test/layoutengine/testcases/
Date Wed, 19 Oct 2005 13:08:27 GMT
Author: jeremias
Date: Wed Oct 19 06:08:17 2005
New Revision: 326547

URL: http://svn.apache.org/viewcvs?rev=326547&view=rev
Log:
Test case for space resolution in the footnote area. Currently disabled as the individual
footnotes don't form a continuous element list where space resolution could be performed.
Bugfix in PageSequenceLayoutManager: LMs are now informed about space resolution results and
the spaces in the element lists don't cause an NPE anymore.
AreaAdditionUtil: the layout manager parameter is now optional so it can be used for footnotes.

Added:
    xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/testcases/footnote_space-resolution.xml
  (with props)
Modified:
    xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/AreaAdditionUtil.java
    xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java
    xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/disabled-testcases.txt

Modified: xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/AreaAdditionUtil.java
URL: http://svn.apache.org/viewcvs/xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/AreaAdditionUtil.java?rev=326547&r1=326546&r2=326547&view=diff
==============================================================================
--- xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/AreaAdditionUtil.java
(original)
+++ xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/AreaAdditionUtil.java
Wed Oct 19 06:08:17 2005
@@ -86,7 +86,7 @@
             }
         }
         
-        if (bslm.markers != null) {
+        if (bslm != null && bslm.markers != null) {
             bslm.getCurrentPV().addMarkers(bslm.markers, true, 
                     bslm.isFirst(firstPos), bslm.isLast(lastPos));
         }
@@ -107,7 +107,7 @@
             lc.setStackLimit(layoutContext.getStackLimit());
             childLM.addAreas(childPosIter, lc);
         }
-        if (bslm.markers != null) {
+        if (bslm != null && bslm.markers != null) {
             bslm.getCurrentPV().addMarkers(bslm.markers, false, 
                     bslm.isFirst(firstPos), bslm.isLast(lastPos));
         }

Modified: xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java
URL: http://svn.apache.org/viewcvs/xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java?rev=326547&r1=326546&r2=326547&view=diff
==============================================================================
--- xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java
(original)
+++ xmlgraphics/fop/branches/Temp_SpaceResolution/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java
Wed Oct 19 06:08:17 2005
@@ -402,10 +402,11 @@
                     int lastIndex = (i == pbp.footnoteLastListIndex 
                             ? pbp.footnoteLastElementIndex : elementList.size() - 1);
 
-                    FootnoteBodyLayoutManager fblm = (FootnoteBodyLayoutManager)
-                            ((KnuthElement) elementList.getFirst()).getLayoutManager();
+                    SpaceResolver.performConditionalsNotification(elementList, 
+                            firstIndex, lastIndex, -1);
                     LayoutContext childLC = new LayoutContext(0);
-                    fblm.addAreas(new KnuthPossPosIter(elementList, firstIndex, lastIndex
+ 1), 
+                    AreaAdditionUtil.addAreas(null, 
+                            new KnuthPossPosIter(elementList, firstIndex, lastIndex + 1),

                             childLC);
                 }
                 // set the offset from the top margin

Modified: xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/disabled-testcases.txt
URL: http://svn.apache.org/viewcvs/xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/disabled-testcases.txt?rev=326547&r1=326546&r2=326547&view=diff
==============================================================================
--- xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/disabled-testcases.txt
(original)
+++ xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/disabled-testcases.txt
Wed Oct 19 06:08:17 2005
@@ -6,6 +6,7 @@
 block_word-spacing.xml
 block_word-spacing_text-align_justify.xml
 external-graphic_oversized.xml
+footnote_space-resolution.xml
 inline-block_keep-together.xml
 inline_block_nested_3.xml
 inline_border_padding_block_nested_2.xml

Added: xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/testcases/footnote_space-resolution.xml
URL: http://svn.apache.org/viewcvs/xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/testcases/footnote_space-resolution.xml?rev=326547&view=auto
==============================================================================
--- xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/testcases/footnote_space-resolution.xml
(added)
+++ xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/testcases/footnote_space-resolution.xml
Wed Oct 19 06:08:17 2005
@@ -0,0 +1,58 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  Copyright 2005 The Apache Software Foundation
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+<!-- $Id$ -->
+<testcase>
+  <info>
+    <p>
+      This test checks space-resolution inside the footnotes area.
+    </p>
+  </info>
+  <fo>
+    <fo:root xmlns:fo="http://www.w3.org/1999/XSL/Format" xmlns:svg="http://www.w3.org/2000/svg">
+      <fo:layout-master-set>
+        <fo:simple-page-master master-name="normal" page-width="5in" page-height="3in">
+          <fo:region-body/>
+        </fo:simple-page-master>
+      </fo:layout-master-set>
+      <fo:page-sequence master-reference="normal" white-space-collapse="true">
+        <fo:flow flow-name="xsl-region-body">
+          <fo:block>region-body<fo:footnote>
+              <fo:inline font-size="50%" vertical-align="super">1</fo:inline>
+              <fo:footnote-body>
+                <fo:block space-before="1em" space-after="1em">
+                  <fo:inline font-size="50%" vertical-align="super">1</fo:inline>I'm
a footnote!</fo:block>
+              </fo:footnote-body>
+            </fo:footnote>
+            blah<fo:footnote>
+              <fo:inline font-size="50%" vertical-align="super">2</fo:inline>
+              <fo:footnote-body>
+                <fo:block space-before="1em" space-after="1em">
+                  <fo:inline font-size="50%" vertical-align="super">2</fo:inline>I'm
a footnote!</fo:block>
+              </fo:footnote-body>
+            </fo:footnote>
+          </fo:block>
+        </fo:flow>
+      </fo:page-sequence>
+    </fo:root>
+  </fo>
+  <checks>
+    <true xpath="not(boolean(//footnotes/block[1]/@space-before))"/>
+    <true xpath="not(boolean(//footnotes/block[1]/@space-after))"/>
+    <eval expected="12000" xpath="//footnotes/block[2]/@space-before"/>
+    <true xpath="not(boolean(//footnotes/block[2]/@space-after))"/>
+  </checks>
+</testcase>

Propchange: xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/testcases/footnote_space-resolution.xml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: xmlgraphics/fop/branches/Temp_SpaceResolution/test/layoutengine/testcases/footnote_space-resolution.xml
------------------------------------------------------------------------------
    svn:keywords = Id



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org


Mime
View raw message