Mailing-List: contact batik-users-help@xmlgraphics.apache.org; run by ezmlm
Precedence: bulk
Reply-To: batik-users@xmlgraphics.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Date: Tue, 5 Aug 2008 23:43:13 +1000 (EST)
From: Paul Solomon <pauls@clearboxsystems.com.au>
To: batik-users <batik-users@xmlgraphics.apache.org>
Message-ID: <21215786.1881217943793752.JavaMail.root@mailbox>
In-Reply-To: <20866394.1861217943680944.JavaMail.root@mailbox>
Subject: Bugfix
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi All,

What is the best way to submit bugfixes? I have found one so far working with batik in the following file. The fix is below

org.apache.batik.util.PreferenceManager

    public Point getPoint(String key)
    {		
	Point defaultValue = (Point)getDefault(key);
        String sp = internal.getProperty(key);
        if (sp == null) {
            return defaultValue;
        }
        Point result = new Point();
        try {
            int x, y;
            String token;
            StringTokenizer st = new StringTokenizer(sp," ", false);
            if (!st.hasMoreTokens()) {
                // the value is not correctly formated => remove it
                internal.remove(key);
                return defaultValue;
            }
            token = st.nextToken();
            x = Integer.parseInt(token);
            if (!st.hasMoreTokens()) {
                internal.remove(key);
                return defaultValue;
            }
            token = st.nextToken();
            y = Integer.parseInt(token);
// ------------- BUG -----  These 4 lines should be removed 
//          if (!st.hasMoreTokens()) {
//            internal.remove(key);
//              return defaultValue;
//          }
            result.setLocation(x,y);
            return result;
        } catch (NumberFormatException e) {
            internal.remove(key);
            return defaultValue;
        }
    }


Regards,

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-users-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-users-help@xmlgraphics.apache.org