Return-Path: Delivered-To: apmail-xmlgraphics-batik-dev-archive@www.apache.org Received: (qmail 40659 invoked from network); 15 Feb 2010 18:54:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Feb 2010 18:54:34 -0000 Received: (qmail 97150 invoked by uid 500); 15 Feb 2010 18:54:34 -0000 Delivered-To: apmail-xmlgraphics-batik-dev-archive@xmlgraphics.apache.org Received: (qmail 97112 invoked by uid 500); 15 Feb 2010 18:54:34 -0000 Mailing-List: contact batik-dev-help@xmlgraphics.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: batik-dev@xmlgraphics.apache.org Delivered-To: mailing list batik-dev@xmlgraphics.apache.org Received: (qmail 97104 invoked by uid 99); 15 Feb 2010 18:54:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Feb 2010 18:54:34 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Feb 2010 18:54:33 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id 7AA2829A0014; Mon, 15 Feb 2010 10:54:11 -0800 (PST) From: bugzilla@apache.org To: batik-dev@xmlgraphics.apache.org Subject: DO NOT REPLY [Bug 48634] [PATCH] The setSize(0) method of LRUCache does not disable the cache X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Batik X-Bugzilla-Component: GVT X-Bugzilla-Keywords: PatchAvailable X-Bugzilla-Severity: major X-Bugzilla-Who: nithril@gmail.com X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: batik-dev@xmlgraphics.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <20100215185413.7AA2829A0014@brutus.apache.org> Date: Mon, 15 Feb 2010 10:54:11 -0800 (PST) https://issues.apache.org/bugzilla/show_bug.cgi?id=48634 --- Comment #15 from Nicolas Labrot 2010-02-15 18:54:09 UTC --- (In reply to comment #13) > (In reply to comment #12) > > My IDE automaticaly right trim lines. The patch contains trim modification for > > regard.xml with the new test. > > I still noticed a few whitespace modification but they now point only towards > trimmed trailing spaces, which I believe to be good. :-) > > > > If there is any new modifications to do, please ask me > > Without a deep idea on what's involved, I did notice a few small things: > > 1. typo: "inconsistant" (should be "inconsistent", found in properties file and > related source code. ;-) > > 2. Whitespace issues found in > "sources/org/apache/batik/ext/awt/image/rendered/LRUCache.java": The file seems > to be using 8 spaces for indenting instead of the usual 4 spaces. This is > somehow inconsistent with the framework but, IMHO, should be fixed maybe in a > follow-up commit and *not* as part of this patch. :-) > Funny because I reconfigure my IDE to reformat the code with 8 spaces like the original file ;) > > I've also fixed the bug title and bug keywords for grammar and to reflect the > availability of a patch. ;-) Thank you ;) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org