xmlgraphics-batik-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 48634] [PATCH] The setSize(0) method of LRUCache does not disable the cache
Date Mon, 15 Feb 2010 18:54:11 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=48634

--- Comment #15 from Nicolas Labrot <nithril@gmail.com> 2010-02-15 18:54:09 UTC ---
(In reply to comment #13)
> (In reply to comment #12)
> > My IDE automaticaly right trim lines. The patch contains trim modification for
> > regard.xml with the new test.
> 
> I still noticed a few whitespace modification but they now point only towards
> trimmed trailing spaces, which I believe to be good. :-)
> 
> 
> > If there is any new modifications to do, please ask me
> 
> Without a deep idea on what's involved, I did notice a few small things:
> 
> 1. typo: "inconsistant" (should be "inconsistent", found in properties file and
> related source code. ;-)
> 
> 2. Whitespace issues found in
> "sources/org/apache/batik/ext/awt/image/rendered/LRUCache.java": The file seems
> to be using 8 spaces for indenting instead of the usual 4 spaces. This is
> somehow inconsistent with the framework but, IMHO, should be fixed maybe in a
> follow-up commit and *not* as part of this patch. :-)
> 

Funny because I reconfigure my IDE to reformat the code with 8 spaces like the
original file ;)


> 
> I've also fixed the bug title and bug keywords for grammar and to reflect the
> availability of a patch. ;-)


Thank you ;)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


Mime
View raw message