xmlgraphics-batik-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46072] Implement Window and Location from 1.2T
Date Wed, 29 Oct 2008 09:40:11 GMT

--- Comment #2 from Helder Magalh <helder.magalhaes@gmail.com>  2008-10-29 02:40:10
PST ---
(In reply to comment #1)
> Created an attachment (id=22786)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22786) [details]
> First attempt patch to allow changing location with script.

Cool! :-)

> + * @version $Id: Loaction.java$

Sounds like a typo.

> null == location

I'd suggest the reverse (location == null) as it's more intuitive and seems to
match the code 

> +     * @param url A string containing the URL where the user agent should
> +     *    navigate.

"should navigate [to]."? ;-)

> However, this is functional and some feedback/review of the implementation is
> appreciated. 

Intuitively it looks well, and I may help testing whenever/if this makes it
into the trunk and/or if someone with more expertise (such as Cameron or
Thomas, for example) states this looks good enough (by applying the patch
locally). Sorry for not being able to provide a deeper review but I'm not that
familiar with Batik codebase yet. ;-)

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org

View raw message