xmlgraphics-batik-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cameron McCormack <...@mcc.id.au>
Subject Re: [PATCHes] Various utilities' fixes
Date Sat, 04 Oct 2008 14:52:48 GMT
Hi Bogdan.

First, thanks for taking the time to submit some patches.  As you
probably noticed, the developers don’t have much bandwidth for Batik
work at the moment, but at some point they’ll be looked at.

In the meantime, a couple of comments.

Bogdan:
> CSSConstants, XMLConstants, SVGContants:
> * make all fields "public static final" instead of "package non-static
>   changeable"

Since CSSConstants, XMLConstants and SVGConstants are interfaces, all
fields are implicitly “public static final”.  Thus there’s no need to
(and, while there’s no official style guide, are usually preferred not
to) explicitly include these modifiers.

> …
>  Perhaps CleanerThread should be an instance of HaltingThread and
> check for halt if the run() method? Perhaps its instance should be
> available then, so the user can halt it?

Yes, it’d probably be good to be able to kill all of the threads Batik
uses when a program has finished using its classes.  I wonder if there
is an easy way to detect this, to do it automatically (if that’s
desirable)?  Track instances of all SoftReferenceCleared/
WeakReferenceCleared/PhantomReferenceCleared objects maybe?

> …
> RunnableQueue:
> …
> * AndWait() methods: returning immediately if the thread is null

Instead of throwing?  It seems to be useful to know if the Runnable was
able to be invoked or not.

> …

Thanks,

Cameron

-- 
Cameron McCormack ≝ http://mcc.id.au/

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


Mime
View raw message