xmlgraphics-batik-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremias Maerki <...@jeremias-maerki.ch>
Subject Re: DO NOT REPLY [Bug 39838] New: - patches to prevent integer overflow
Date Tue, 20 Jun 2006 13:20:28 GMT

On 20.06.2006 15:15:09 Cameron McCormack wrote:
> Jeremias Maerki:
> > you are now a committer in Batik. You can apply these changes yourself
> > if you think they don't need to be discussed (commit-review). The
> > approach you've chosen is only necessary if you have a change that could
> > be subject for discussion (review-commit).
> 
> Oh and another thing I meant to mention, Dieter.  Any file that you make
> any changes to (that aren’t trivial reformatting or something similarly
> small) should have its copyright message updated so that the current
> year is included.

Actually, that's not important anymore. Shortly, there will be an
announcement about a policy change concerning the license header. It
will be changed again and the new one will not have a copyright year
anymore. Cliff Schmidt (ASF VP, legal affairs) is currently finalizing
all necessary information. Stay tuned.

> One thing in the code:
> 
>   Index: org/apache/batik/css/engine/StringIntMap.java
>   …
>   -       if (count++ >= (len * 3) >>> 2) {
>   +       if (count++ >= len - ( len >>> 2 )) {
> 
> Note that these two expressions are slightly different.  For example
> when len == 5, the first expression checks >= 3, while the second checks
> >= 4.  It doesn’t really matter in this case, though, since it’s just
> used as a rough check for when the hash table is getting full.  If you
> realised this, don’t mind me.
> 
> Thinking aloud: should we have a code style policy, as FOP does?

Doesn't hurt. :-) I guess we will need one for XML Graphics Commons
unless we want a wide range of styles. But even in FOP we haven't fixed
all style "violations", yet.

Jeremias Maerki


---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


Mime
View raw message