xmlgraphics-batik-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas DeWeese <Thomas.DeWe...@Kodak.com>
Subject Re: submit preserveAspectRatio stuff
Date Mon, 30 Aug 2004 19:16:48 GMT
Hi Tonny,

    All the Copyrights say 2000-2003, I assume this is not in fact
correct (or else you've been developing this since before the first
dynamic release of Batik ;).

    What should they be? (what years did the development occur in).

Tonny Kohar wrote:

> Hi,
> 
> I just updated the preserveAspectRatio with diff patch format.
> The new file is in bugzilla id: 30580.
> 
> This time is contains patch.diff file and all the source file and
> test-case, hopefully this is the correct format for diff stuff :)
> 
> 
>>    Two things.  First off I can see where the change goes int
>>SVGOMViewElement, but I don't see that SVGOMUseElement has a
>>getPreserveAspectRatio method (although I suppose this could
>>be a bug in the spec).
> 
> 
> I also updated all the element that reference preserveAspectRatio which
> is
> - SVGOMImageElement
> - SVGOMPatternElement
> - SVGOMSVGElement
> - SGOMSymbolElement
> - SVGOMMarkerElement
> - SVGOMViewElement
> 
> 
>>    Also can you provide a testcase for this?  The simplest thing
>>to do would be to write an SVG file with some embedded javascript
>>that uses this interface to populate some text elements in the
>>document.  This can then be tied into our regression testing
>>facilities to ensure it continues to do the right thing down
>>the line.  If you wanted to test update handling as well
>>(if you set the property through setAttribute and then query
>>via the PAR interface do you get the correct updated values) that
>>would be great.
> 
> 
> A test case is included also, it is under
> test-resources/org/apache/batik/dom/svg/bug30580.svg
> 
> Best Regards
> Tonny Kohar


---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: batik-dev-help@xml.apache.org


Mime
View raw message