xml-rpc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject cvs commit: xml-rpc/src/java/org/apache/xmlrpc/secure SecureWebServer.java
Date Sat, 11 Aug 2001 10:15:52 GMT
dlr         01/08/11 03:15:52

  Modified:    src/java/org/apache/xmlrpc/secure SecureWebServer.java
  Log:
  Override WebServer's createServerSocket() hook method.
  setupServerSocket() is responsible for setting socket timeout, so we
  don't want to override that method.  setupServerSocket() should
  probably be private in WebServer, or final (though I don't see any
  reason for it to remain public).  I vote for deprecating it, then
  inlining its code.
  
  Revision  Changes    Path
  1.2       +6 -3      xml-rpc/src/java/org/apache/xmlrpc/secure/SecureWebServer.java
  
  Index: SecureWebServer.java
  ===================================================================
  RCS file: /home/cvs/xml-rpc/src/java/org/apache/xmlrpc/secure/SecureWebServer.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -u -r1.1 -r1.2
  --- SecureWebServer.java	2001/07/20 19:38:19	1.1
  +++ SecureWebServer.java	2001/08/11 10:15:52	1.2
  @@ -83,7 +83,7 @@
    * values before anything will work.
    *
    * @author <a href="mailto:jvanzyl@apache.org">Jason van Zyl</a>
  - * @version $Id: SecureWebServer.java,v 1.1 2001/07/20 19:38:19 jvanzyl Exp $
  + * @version $Id: SecureWebServer.java,v 1.2 2001/08/11 10:15:52 dlr Exp $
    */
   public class SecureWebServer 
       extends WebServer
  @@ -111,7 +111,10 @@
           super(port,add);
       }
   
  -    public void setupServerSocket(int port, int backlog, InetAddress add)
  +    /**
  +     * @see org.apache.xmlrpc.WebServer#createServerSocket(int port, int backlog, InetAddress
add)
  +     */
  +    protected ServerSocket createServerSocket(int port, int backlog, InetAddress add)
           throws Exception
       {
           SecurityTool.setup();
  @@ -130,7 +133,7 @@
               
           context.init(keyManagerFactory.getKeyManagers(), null, null);
           SSLServerSocketFactory sslSrvFact = context.getServerSocketFactory();
  -        serverSocket = (SSLServerSocket) sslSrvFact.createServerSocket(port);
  +        return (SSLServerSocket) sslSrvFact.createServerSocket(port);
       }
   
       /**
  
  
  

Mime
View raw message