xml-commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 38316] - [sax][patch] Fix for Attributes2Impl issues
Date Sat, 25 Feb 2006 07:24:01 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38316>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38316





------- Additional Comments From mrglavas@ca.ibm.com  2006-02-25 08:23 -------
Looks pretty good. A couple things jumped out at me while reviewing it. The use 
of java.util.Arrays creates a dependency on JDK 1.2. I'm pretty sure the SAX 
API otherwise compiles on JDK 1.1.8. The Arrays class is being used to set all 
of the values in the data array to false when the Attributes object is cleared. 
I don't see the benefit of that. It appears that when the data array is 
created, its initial size will always be 100 which seems a bit too large.

A discussion [1] has just started on the SAX development list which has sparked 
the possibility of a new maintenance release of SAX (I guess it would be SAX 
2.0.3). On the thread, I mentioned the bugs in Attributes2Impl and cited this 
report (in addition to the other two [2][3]). I would like to see the ASF copy 
of SAX stay in synch with the official distribution. Perhaps your patch will 
get merged into it. I'm going to hold off making changes here until there's a 
resolution in the SAX community.

[1] http://sourceforge.net/mailarchive/forum.php?thread_id=9795444&forum_id=1472
[2] https://sourceforge.net/tracker/index.php?
func=detail&aid=1207064&group_id=29449&atid=396219
[3] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6205431

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Mime
View raw message