xalan-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven J. Hathaway (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (XALANC-666) [PATCH] Fedora patches for xalan-c
Date Wed, 31 Oct 2012 05:11:11 GMT

     [ https://issues.apache.org/jira/browse/XALANC-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Steven J. Hathaway closed XALANC-666.

    Resolution: Won't Fix

Wont fix without further review.  Version 1.11 compiles using GCC 4.4.5
> [PATCH] Fedora patches for xalan-c
> ----------------------------------
>                 Key: XALANC-666
>                 URL: https://issues.apache.org/jira/browse/XALANC-666
>             Project: XalanC
>          Issue Type: Bug
>          Components: XalanC
>    Affects Versions: CurrentCVS
>            Reporter: Lubomir Kundrak
>             Fix For: CurrentCVS
> Sorry for including distinct issues in one report, but it was originally a mail meant
for a mailing list, but didn't seem to pass through moderation
> **********
> Hi,
> Hopefully I am contacting the right place; Jira seems to be down at the
> time.
> There are two simple patches we use in Fedora for xalan-c to compile
> correctly, so I suggest you include them in next release so that also
> other packagers can benefit:
> 1.) Missing header file includes for gcc-4.3: A test build of all Fedora
> packages with new gcc branch was done and xalan-c did not build. New C++
> compiler headers were cleaned from unnecessary includes, so applications
> who did not include ones they use explicitly failed to build and xalan-c
> was among them. We use a patch [1] to fix it.
> 2.) We pass several flags to the compiler, most notably the stack
> protector option and FORTIFY_SOURCE macro definition. The "-z" argument
> is being processed by getopt which traditionally uses space as argument
> delimeter only and disallows any use of it in arguments. The getopt
> utility that comes from util-linux can pass the argument values properly
> escaped, so that use of space works. Our patch changes that [2]. Note
> that it most likely won't work in non-Linux based systems -- another
> possible choice is using a environment variable to honor the C compiler
> flags (CFLAGS)?
> [1] http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/xalan-c/devel/xalan-c-1.10.0-gcc43.patch
> [2] http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/xalan-c/devel/xalan-c-1.10.0-escaping.patch
> And two more suggestions from the person that did the review of the
> package before it made it into Fedora [3]:
> > - Might ask upsteam to not ship CVS dirs in their release tar to
> > avoid you having to remove them.
> Perhaps use "cvs export" instead of "cvs checkout" when making a release
> tarball?
> > - The upstream web page confusingly calls this "Xalan-C++", even tho
> > the release tar, download dirs and other places call it xalan-c.
> > Perhaps ask them which it really should be?
> [3] https://bugzilla.redhat.com/show_bug.cgi?id=xalan-c-review#c3
> Thanks,
> -- 
> Lubomir Kundrak (Red Hat Security Response Team)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org

View raw message